[bisq-network/bisq] Add missing @Named annotations for CoinFormatter injection (#3658)

Ɓukasz Usarz notifications at github.com
Fri Nov 22 09:43:51 UTC 2019


lusarz commented on this pull request.



> @@ -139,7 +142,7 @@
     public DisputeView(DisputeManager<? extends DisputeList<? extends DisputeList>> disputeManager,
                        KeyRing keyRing,
                        TradeManager tradeManager,
-                       CoinFormatter formatter,
+                       @Named(FormattingUtils.BTC_FORMATTER_KEY) CoinFormatter formatter,

I agree that probably only these two views needs to be annotated. 

Yeah, I suppose `@FxmlView` on abstract views are leftovers, and it would be nice to remove them.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3658#discussion_r349509039
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191122/15fdf11c/attachment-0001.html>


More information about the bisq-github mailing list