[bisq-network/bisq] Add missing @Named annotations for CoinFormatter injection (#3658)

Christoph Atteneder notifications at github.com
Fri Nov 22 09:59:27 UTC 2019


> I have force pushed removing the annotation from the abstract classes.
> 
> I have consistently used
> 
> ```
> import javax.inject.Named;
> ```
> 
> To mirror the usage of
> 
> ```
> import javax.inject.Inject;
> ```
> 
> These are library agnostic and should still be effective if a different DI framework is used. I didn't notice that another import was used elsewhere.

I guess we should get rid of the Guice bound annotations in favor of the generic one at some point.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3658#issuecomment-557469397
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191122/8a7db01d/attachment.html>


More information about the bisq-github mailing list