[bisq-network/bisq] Split EmptyWalletWindow into BsqEmptyWalletWindow and BtcEmptyWalletWindow (#3660)
Ćukasz Usarz
notifications at github.com
Fri Nov 22 13:28:09 UTC 2019
There is a lot of checks like:
if (!isBtc)
gridPane.getColumnConstraints().remove(1);
if (isBtc)
addMultilineLabel(gridPane, ++rowIndex, Res.get("emptyWalletWindow.info"), 0);
in [EmptyWalletWindow](https://github.com/bisq-network/bisq/blob/a26366ee0d5f4991e3807e65d475d01a2451e26b/desktop/src/main/java/bisq/desktop/main/overlays/windows/EmptyWalletWindow.java)
In this pull request I split this logic into separate classes, to make it more readable.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/3660
-- Commit Summary --
* Split EmptyWalletWindow into BsqEmptyWalletWindow and BtcEmptyWalletWindow
-- File Changes --
M desktop/src/main/java/bisq/desktop/app/BisqApp.java (19)
A desktop/src/main/java/bisq/desktop/main/overlays/windows/BsqEmptyWalletWindow.java (87)
R desktop/src/main/java/bisq/desktop/main/overlays/windows/BtcEmptyWalletWindow.java (156)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/3660.patch
https://github.com/bisq-network/bisq/pull/3660.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3660
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191122/87818074/attachment.html>
More information about the bisq-github
mailing list