[bisq-network/bisq] Cleanup fmxlview and javax imports (#3661)

Chris Beams notifications at github.com
Fri Nov 22 20:18:37 UTC 2019


cbeams commented on this pull request.

utACK assuming a valid answer to my comment.

> @@ -54,7 +50,7 @@ public DisputeAgentView(DisputeManager<? extends DisputeList<? extends DisputeLi
                             ContractWindow contractWindow,
                             TradeDetailsWindow tradeDetailsWindow,
                             AccountAgeWitnessService accountAgeWitnessService,
-                            @Named(AppOptionKeys.USE_DEV_PRIVILEGE_KEYS) boolean useDevPrivilegeKeys) {

It's not obvious to me why injection of this value would still work without the explicit annotation. The value of `AppOptionKeys.USE_DEV_PRIVILEGE_KEYS` is in fact "useDevPrivilegeKeys", spelled exactly the same as the `useDevPrivilegeKeys` parameter, so in theory Guice could introspect and do the injection based on that, but this information is not inspectable at runtime unless the `-parameters` option has been passed to javac to keep the parameter symbol table available (and our build does not do this). What am I missing?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3661#pullrequestreview-321786884
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191122/ab57b60e/attachment.html>


More information about the bisq-github mailing list