[bisq-network/bisq] A timeout occurred. (#3602)

[Steven Barclay]

I had a look through the attached logfile earlier. It appears that the issue is due to an inconsistency between the way `bisq.core.payment.ReceiptValidator` checks for a match between offer-taker bank account types (as used by the Offer Book & Take Offer views) and the validation later done in the constructor of `bisq.core.trade.Contract`. The latter is causing an error at the other end, as seen in the logfile:

> Nov-12 19:45:19.885 [JavaFX Application Thread] WARN  b.c.t.p.TradeProtocol: Received AckMessage with error state for InputsForDepositTxRequest from iocd6eflopmyvjkf.onion:9999 with tradeId 0c8skf-0656b80f-90b7-4a8b-9db5-aaef284cd632-123 and errorMessage=An error occurred at task: MakerCreateAndSignContract
Exception message: payment methods of maker and taker must be the same.
makerPaymentMethodId=SAME_BANK
takerPaymentMethodId=NATIONAL_BANK 

(It's not clear exactly why the taker is presented with a timeout error message, however.)

The validation done by `Contract` is stricter, as seen by the lines:

> `        String makerPaymentMethodId = makerPaymentAccountPayload.getPaymentMethodId();`
>`        String takerPaymentMethodId = takerPaymentAccountPayload.getPaymentMethodId();`
>`        // For SEPA offers we accept also SEPA_INSTANT takers`
>`        // Otherwise both ids need to be the same`
>`        boolean result = (makerPaymentMethodId.equals(PaymentMethod.SEPA_ID) && takerPaymentMethodId.equals(PaymentMethod.SEPA_INSTANT_ID)) ||`
>`                makerPaymentMethodId.equals(takerPaymentMethodId);`
>`        checkArgument(result, "payment methods of maker and taker must be the same.\n" +`
>`                "makerPaymentMethodId=" + makerPaymentMethodId + "\n" +`
>`                "takerPaymentMethodId=" + takerPaymentMethodId);`

The restriction that both payment method IDs are identical (except for SEPA offers) should possibly be relaxed to match the logic done in `ReceiptValidator`, which allows _SAME_BANK_ offers to be taken by _NATIONAL_BANK_ account holders when the country and bank IDs match.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3602#issuecomment-557712436
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191122/ffd0c7a7/attachment.html>