[bisq-network/bisq] (7/7) [BUGFIX] Fix duplicate sequence number use case (Non-persistent ProtectedStoragePayloads) (#3665)

Julian Knutsen notifications at github.com
Fri Nov 22 23:27:04 UTC 2019


julianknutsen commented on this pull request.



> @@ -188,15 +188,5 @@ public void removeExpiredEntries_PurgeSeqNrMap() throws CryptoException, NoSuchA
         SavedTestState beforeState = this.testState.saveTestState(purgedProtectedStorageEntry);
         this.testState.mockedStorage.removeExpiredEntries();
         this.testState.verifyProtectedStorageRemove(beforeState, expectedRemoves, true, true, false, false, false);
-

This test was testing too much when just calling verifyProtectedStorageRemove() gives us what we want. 

But, the failure did point out that we add expirable ProtectedStorageEntrys and then immediately expire them in the next expire cycle. I'll put this on my backlog to fix it. Not super urgent.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3665#pullrequestreview-321862184
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191122/99245342/attachment.html>


More information about the bisq-github mailing list