[bisq-network/bisq] (8/8) Test and Refactor P2PDataStorage Synchronization Path (#3667)

[Julian Knutsen]

julianknutsen commented on this pull request.



> @@ -315,9 +308,7 @@ private boolean shouldTransmitPayloadToPeer(Capabilities peerCapabilities, Netwo
                 doAdd = true;
             }
             if (doAdd) {
-                boolean notContained = lookupSet.add(protectedStoragePayload.hashCode());

@chimp1984 I could use your prior knowledge for the behavior. Do you know of any cases where we intentionally want/expect the payload hash and the hashCode to be different?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3667#pullrequestreview-321921304
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191123/57e9ced5/attachment.html>