[bisq-network/bisq] Prevent taking of offers with unequal bank account types (excl. SEPA) (#3673)

[Steven Barclay]

Use stricter criteria when deciding which of the taker's accounts (if any) are valid for a given offer. Specifically, prevent National Bank accounts from being used to take Same / Specific Bank(s) offers, so the three payment method types can never being mixed.

This prevents an error on the trading peer when the trade starts, due to enforcement of equal maker & taker payment method IDs (except for SEPA) in the Contract payload constructor.

This partially addresses #3602, where the erroneous peer response caused the taker to be presented with a confusing timeout, after they managed to take a _SAME_BANK_ offer using their _NATIONAL_BANK_ account. With this change, the taker would be directed to create a separate _SAME_BANK_ account if they don't have one already (which would then be automatically selected).

(Later, it might be worthwhile to make a more substantial change to allow National, Same or Specific Bank account types to be mixed under certain circumstances when trading, but that could be complicated by the peer running an older version.)
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3673

-- Commit Summary --

  * Use strict stubbing for ReceiptValidatorTest to avoid confusion
  * Prevent taking of offers with unequal bank account types

-- File Changes --

    M core/src/main/java/bisq/core/payment/ReceiptValidator.java (7)
    M core/src/test/java/bisq/core/payment/ReceiptValidatorTest.java (82)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3673.patch
https://github.com/bisq-network/bisq/pull/3673.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3673
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191123/c7ed66ca/attachment.html>