[bisq-network/bisq] Add missing @Named annotations for CoinFormatter injection (#3658)

[chimp1984]

chimp1984 commented on this pull request.



> @@ -139,7 +142,7 @@
     public DisputeView(DisputeManager<? extends DisputeList<? extends DisputeList>> disputeManager,
                        KeyRing keyRing,
                        TradeManager tradeManager,
-                       CoinFormatter formatter,
+                       @Named(FormattingUtils.BTC_FORMATTER_KEY) CoinFormatter formatter,

Inject annotation is needed for the concrete classes but not for the base classes (should not be used there). It probably crashed due some nullpointers caused if the annotation is missing but with view classed you don't get proper error logs.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3658#discussion_r349937394
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191124/ed87362b/attachment.html>