[bisq-network/bisq] Fix #3662: Malformed trade chat & dispute speech bubbles (#3680)

[Steven Barclay]

Prevent the 'arrow' of a message bubble from being sporadically anchored to the wrong side - appearing on the left instead of the right hand side of the bubble. This is due to the same `ListCell` object being reused by JavaFX for different bubbles as the user scrolls up and down the chat pane, which requires that the anchors of each arrow be properly cleared between `ListCell.updateItem(..)` calls.

To this end, move the block of `AnchorPane.clearConstraints(..)` calls to the beginning of the `updateItem(..) method`, as the apparent assumption that `updateItem(item, empty = true)` will always be called to clear the given `ListCell` before reusing it as a new bubble turns out to be wrong.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3680

-- Commit Summary --

  * Fix #3662: Malformed trade chat & dispute speech bubbles

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/shared/ChatView.java (23)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3680.patch
https://github.com/bisq-network/bisq/pull/3680.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3680
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191124/71fad556/attachment.html>