[bisq-network/bisq-website] Add Schema.org JSON-LD Microdata for SEO (Homepage) (#290)

Steve Jain notifications at github.com
Mon Nov 25 18:15:41 UTC 2019


m52go requested changes on this pull request.

Thanks for this—seems like low-hanging fruit to improve site traffic and perhaps downloads. 

Some of my comments might be subjective, but I would say that such unclear things are better left unspecified/omitted.

> @@ -63,6 +63,60 @@
         <script defer src="/js/bootstrap.min.js"></script>
         <script defer src="/js/scripts.js"></script>
 
+        <!-- Schema.org JSON-LD Markup for Search Engine Optimization -->
+        <script type='application/ld+json'>
+        {
+            "@context": "https://schema.org/",
+            "@type": "SoftwareApplication",
+            "applicationCategory": "FinanceApplication",
+            "name": "Bisq",
+            "image": "https://bisq.network/images/bisq-logo.svg",
+            "availableOnDevice": [

Bisq isn't available on mobile devices right now...just desktop. There is a notifications app, but I don't think it's right to classify that as Bisq "being available" on those platforms.

> @@ -63,6 +63,60 @@
         <script defer src="/js/bootstrap.min.js"></script>
         <script defer src="/js/scripts.js"></script>
 
+        <!-- Schema.org JSON-LD Markup for Search Engine Optimization -->
+        <script type='application/ld+json'>
+        {
+            "@context": "https://schema.org/",
+            "@type": "SoftwareApplication",
+            "applicationCategory": "FinanceApplication",
+            "name": "Bisq",
+            "image": "https://bisq.network/images/bisq-logo.svg",
+            "availableOnDevice": [
+                "Desktop",
+                "Smartphone",
+                "Tablet"
+            ],
+            "author": {
+            "@type": "Organization",

The Bisq DAO isn't really an organization...it's just a loose group of individuals who contribute to the software. I would prefer to see this `author` attribute removed, even if it comes at the expense of some clicks, since it's a legal grey area.

> +            "name": "Bisq Decentralized Autonomous Organization",
+            "sameAs": [
+                "https://github.com/bisq-network",
+                "https://twitter.com/bisq_network",
+                "https://www.youtube.com/c/bisq-network",
+                "https://bisq.network/slack-invite",
+                "https://bisq.community/",
+                "https://lists.bisq.network/listinfo/bisq-contrib",
+                "https://webchat.freenode.net/?channels=bisq",
+                "https://www.reddit.com/r/bisq",
+                "https://keybase.io/team/bisq"
+	          ]
+            },
+            "downloadUrl": "https://bisq.network/downloads/",
+            "fileSize": "180MB",
+            "operatingSystem": [

See above comment—iOS and Android should be removed.

> +                "https://keybase.io/team/bisq"
+	          ]
+            },
+            "downloadUrl": "https://bisq.network/downloads/",
+            "fileSize": "180MB",
+            "operatingSystem": [
+                "Windows",
+                "Linux",
+                "OSX",
+                "iOs",
+                "Android"
+            ],
+            "releaseNotes": "https://github.com/bisq-network/bisq/releases",
+            "screenshot": "https://bisq.network/images/bisq_screen0.svg",
+            "softwareVersion": "{{ site.client_version }}",
+            "aggregateRating": {

Where's this rating data from? If it's a placeholder/dummy data then I think it's better to omit it.

> +            "operatingSystem": [
+                "Windows",
+                "Linux",
+                "OSX",
+                "iOs",
+                "Android"
+            ],
+            "releaseNotes": "https://github.com/bisq-network/bisq/releases",
+            "screenshot": "https://bisq.network/images/bisq_screen0.svg",
+            "softwareVersion": "{{ site.client_version }}",
+            "aggregateRating": {
+            "@type": "AggregateRating",
+            "ratingValue": "5",
+            "ratingCount": "20"
+          },
+          "offers": {

Bisq itself doesn't exchange bitcoin, so I think it's better to omit this too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/290#pullrequestreview-322478959
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191125/950c536e/attachment-0001.html>


More information about the bisq-github mailing list