[bisq-network/bisq] (7/7) FileManager.java Cleanup and Audit (#3690)

[Julian Knutsen]

@freimair @chimp1984 This is what I found in the day of auditing.

I agree that some users pass in references that are not thread-safe, but fixing that requires a real design and implementation plan that is outside of the scope of my current work. I've outlined a potential solution in the `Future Work` section for anyone else who is interested or assigned to fix that technical debt.

Feel free to take this or trash it. I'm also happy to just close my open PR that fixes the persistence bug in `TempProposalStore`. The amount of overhead maintaining these patches for weeks isn't worth my time if they are known issues and we don't have the resources to fix them.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3690#issuecomment-558393270
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191125/b25028a8/attachment.html>