[bisq-network/bisq] Backup, restore and create a new onion address via GUI (#3044)

[Devin Bileck]

I verified the connecting-to-self issue and the issue where messages sent to an "old" hidden service got discarded have been resolved.

Regarding cleaning unused hidden services on shutdown, I noticed when generating a new address and restarting (without open trades/offers), both addresses are still in use (as seen in the log). And possibly as a result, it listed a seednode twice in the connected peers list (possibly from each address connecting to it?):
![image](https://user-images.githubusercontent.com/603793/69610627-0be77d80-0fe1-11ea-996b-18dc85b408bb.png)

On the next restart, the old address is no longer active. So it does take an additional shutdown to clean the unused address. I am not sure if it failed to clean it up initially or if it needs an additional check on startup for cleanup?

Additionally, I still feel the GUI should explicitly indicate all onion addresses in use so it is clear to the user. Though I am not sure the best way to present it since each could potentially have different peer connections. Possibly a future improvement idea?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3044#issuecomment-558527172
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191126/9d4fe9f6/attachment.html>