[bisq-network/bisq] Backup, restore and create a new onion address via GUI (#3044)

[Florian Reimair]

>  I noticed when generating a new address and restarting (without open trades/offers), both addresses are still in use

hm I have not encountered this case. Will look into it.

> it listed a seednode twice in the connected peers list 

I have not encountered this case. Will look into it.

> I am not sure if it failed to clean it up initially or if it needs an additional check on startup for cleanup?

if cleaning unused hidden services on startup would be easy, I would have done it right away. The issue is the async way of services getting started - by the time Bisq can assess which HS to keep, all HSs are already up and running (at least most of the time). So no luck here.

> Additionally, I still feel the GUI should explicitly indicate all onion addresses in use...

we could just add a field "legacy onion addresses" with a list of onion addresses still in use, but I am not sure if that can easily be understood by the average Joe. As for the connections, the legacy HS should only receive connections from peers which know the onion address so I see no need for adding an additional connection listing. All in all, I would suggest to get the GUI as is into production and see if and how people actually use it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3044#issuecomment-558577528
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191126/476cc056/attachment.html>