[bisq-network/bisq] Add short cut list (#3695)

Julian Knutsen notifications at github.com
Tue Nov 26 19:12:02 UTC 2019


julianknutsen commented on this pull request.

NIT and questions

> @@ -275,7 +275,7 @@ private void addSceneKeyEventHandler(Scene scene, Injector injector) {
                     injector.getInstance(SendAlertMessageWindow.class).show();
                 } else if (Utilities.isAltOrCtrlPressed(KeyCode.F, keyEvent)) {
                     injector.getInstance(FilterWindow.class).show();
-                } else if (Utilities.isAltOrCtrlPressed(KeyCode.UP, keyEvent)) {

Comments should be updated https://github.com/bisq-network/bisq/blob/3854907c14357680038661c8153095a157efbc5d/core/src/main/java/bisq/core/dao/governance/voteresult/MissingDataRequestService.java#L81

>              if (Utilities.isAltOrCtrlPressed(KeyCode.R, event)) {
                 if (revertTxColumn.isVisible()) {
                     confidenceColumn.getStyleClass().remove("last-column");
                 } else {
                     confidenceColumn.getStyleClass().add("last-column");
                 }
                 revertTxColumn.setVisible(!revertTxColumn.isVisible());
-            } else if (Utilities.isAltOrCtrlPressed(KeyCode.A, event))

Is there an issue tracking the effort to update the website with the new fee information? For example, the Fees section of https://docs.bisq.network/exchange/whitepaper.html still lists that part of the fee goes to the arbitrator.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3695#pullrequestreview-323214319
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191126/184464d3/attachment.html>


More information about the bisq-github mailing list