[bisq-network/bisq] Compensation Request Amount Validation Text Should Display Max Request Allowed (#3703)
Julian Knutsen
notifications at github.com
Wed Nov 27 19:50:54 UTC 2019
<!--
SUPPORT REQUESTS: This is for reporting bugs in the Bisq app.
If you have a support request, please join #support on Bisq's
Keybase team at https://keybase.io/team/Bisq
-->
### Description
When putting in a requested BSQ amount larger than 8 digits, the validation defaults to "Input larger than maximum possible amount is not allowed." instead of listing the maximum amount.
#### Version
548a21775
### Steps to reproduce
1. Start regtest cluster with existing dao-setup.zip contents
2. Create a new compensation request
3. Put in 7 digit request
### Expected behavior
Red validation error with maximum bound of request
### Actual behavior
Input larger than maximum possible amount is not allowed
### Screenshots
<= 8 digits
![compensation_request_large_smaller_number](https://user-images.githubusercontent.com/8082291/69754901-e3a86d80-110b-11ea-8f8f-7eed44ccadf9.JPG)
\> 8 digits
![compensation_request_large_number](https://user-images.githubusercontent.com/8082291/69754905-e6a35e00-110b-11ea-9c43-cb702f22b101.JPG)
#### Device or machine
Ubuntu 19.10
#### Additional info
These test cases are part of the TestPad test plan, but shouldn't ever pass. I don't know if it is worth creating bugs for each of these, but there is likely a lot of debt in this area.
The only validation that is performed is the base InputValidator which only checks for empty strings right now.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3703
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191127/3cd113e1/attachment.html>
More information about the bisq-github
mailing list