[bisq-network/bisq] Makers trade remains open without indicating error if deposit transaction fails for taker (#3705)

[Devin Bileck]

### Description

If the deposit transaction fails for the taker, the trade moves into the failed trades section for them but remains open for the maker without any indication of an error. I would expect the maker to receive notification of the error and the trade to indicate the error state. Instead, they likely wait for the time to run out, with any attempts to contact the taker going unanswered (since chat messages are not shown to them for failed trades), and then the maker finally opens a support ticket.

#### Version

release/v.1.2.4 (commit hash 548a217751b44abab8452cef609ebefb420835f0)

### Steps to reproduce

Using a regtest setup, perform the following steps without generating any blocks:
1. Alice makes about 15 offers to buy BTC
2. Bob tries to take all the offers to sell BTC

### Actual behaviour

When attempting to take the 13th offer, Bob will encounter a transaction rejection error, and the trade will move into his Failed Trades tab. Meanwhile, the trade will show in Alice's open trades without any indication that an error occurred on the takers side. And even after generating several blocks, remains waiting for blockchain confirmation (note, I did see on a few attempts to reproduce this issue that it did eventually get confirmed after several blocks).

### Expected behaviour

After Bob encounters the transaction rejection error, Alice's trade should update and indicate an error was encountered, so that she is informed and can open a support ticket.

### Screenshots

![image](https://user-images.githubusercontent.com/603793/69756475-7d254e80-110f-11ea-9b05-a881ff4b264d.png)

![image](https://user-images.githubusercontent.com/603793/69756481-80b8d580-110f-11ea-990c-7aa6d0685d3c.png)

#### Device or machine

Windows 10

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3705
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191127/b7966544/attachment-0001.html>