[bisq-network/bisq] [1.2.4] Wrong version number in 1.2.4 release branch (#3707)

[Chris Beams]

> I wonder if it would be beneficial to try to implement versioning based on git commit hash?

I'd very much like to go this route, and I actually implemented it in the (now archived) bisq-pricenode repository at one point. Have a look at bisq-network/bisq-pricenode at 64f51ee, which introduces Palantir's git-version Gradle plugin, and the subsequent bisq-network/bisq-pricenode at 26a0247 which reverts it. The reasons for backing that change out had to do with the hosting provider I was using for my pricenode (Heroku) not being able to support the change. I am no longer hosting there, and I believe no one else is either. If we have anyone hosting seednodes or pricenodes, etc in a Git-based push-to-deploy workflow like Heroku's, we should validate that this change won't be a problem for them, but I doubt that anyone is working that way. /cc @bisq-network/seednode-operators, @bisq-network/pricenode-operators.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3707#issuecomment-559617543
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191128/941f5ea8/attachment.html>