[bisq-network/bisq] Create Offer info popup steals focus and causes validation errors (#3715)

[Chris Beams]

<!--
   SUPPORT REQUESTS: This is for reporting bugs in the Bisq app.
   If you have a support request, please join #support on Bisq's
   Keybase team at https://keybase.io/team/Bisq
-->

### Description

When entering the Create Offer screen, an information popup appears that steals cursor focus from the form, triggering validation errors. When the user dismisses the popup, they are left looking a screen full of scary red errors. See screenshots below.

Because this happens only to users who have not already clicked the "Don't show again" checkbox on that popup, it means that every new / first-time Bisq user experiences it. Likewise, we (experienced users) don't often run into it because we've long since suppressed that popup.


#### Version

release/v1.2.4 (commit 548a21775)


### Steps to reproduce

1. Go to Account->National currency accounts->Add new account and set up a fiat payment account, e.g. Zelle
1. Go to Settings and click "Reset all 'don't show again' flags" to ensure you see the popup in question
1. Go to Market and click "Create new offer to buy BTC"
1. The Create Offer screen appears and the info popup appears immediately afterward
1. Notice the red validation errors appear in the background and persist after dismissing the popup by clicking "I confirm"

Workaround (if you can call it that):
1. Close the Create Offer screen and enter it again by clicking on "Create new offer to buy BTC"
1. This time, when the popup appears, click "Don't show again" and then click "I confirm" to dismiss it.
1. Repeat step (1), notice that the popup does not appear, and that the form is presented without any validation errors.

### Expected behaviour

Validation errors should appear only when the user has actually engaged with the form andt entered something invalid.

### Actual behaviour

Validation errors appear no matter what the (first time) user does, creating a poor/frightening experience.

### Screenshots

On entering the Create Offer screen for the first time (note the red validation errors in the background):
<img width="1348" alt="image" src="https://user-images.githubusercontent.com/301810/69835490-574c9680-1242-11ea-962d-7c9747f89ab2.png">

What the user is left looking at when they click "I Confirm" to dismiss the popup:
<img width="1392" alt="image" src="https://user-images.githubusercontent.com/301810/69835535-97137e00-1242-11ea-9ee5-ddcbb157598a.png">

#### Device or machine

macOS 10.14.6



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3715
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191128/4d38c33c/attachment-0001.html>