[bisq-network/bisq-website] New multilanguage system (#260)

[Steve Jain]

m52go commented on this pull request.

I think we're getting there! Attached a couple of comments.

> @@ -1,13 +1,18 @@
 title: Bisq
 url: "https://bisq.network"
 markdown: kramdown
-permalink: /blog/:title/
+permalink: /blog:title/

Was this change a mistake?

Result:

![Screenshot from 2019-10-02 16-24-12](https://user-images.githubusercontent.com/735155/66078987-29dcb880-e531-11e9-9e4e-50d5474df621.png)


> @@ -18,7 +23,7 @@ exclude:
   - README
   - Gemfile
 paginate: 10
-paginate_path: "/blog/page/:num/"
+paginate_path: "/blog/page:num/"

Same as above...there should be a slash.

>            <div class="dropdown-item btn-icon">
             <div class="float-right">
-              <a href="{{ page.url }}" hreflang="{{ page.lang }}">{{ page.language }} {{ page.flag }}</a>
+               {% if item.tag == "en" %}
+               <a href="/">{{ item.name }} {{ item.flag }}</a>
+			   {% else %}
+			   <!-- we use the 'tag' variable in languages.yml to redirect to the correct page -->
+			   <a href="/{{ item.tag}}/" hreflang="{{ site.lang }}">{{ item.name }} {{ item.flag }}</a>

Right now, choosing a new language loads the translation of the current page. With this PR, choosing a new language always loads the home page in the chosen language.

Not a deal-breaker, in my opinion, but worth pointing out. Maybe something to be fixed later.

>                        </div>
 
 
-                      <a href="/{{ page.lang }}/downloads" class="downloads-mobile btn btn-lg btn-outline-secondary btn-icon hero-btn col-sm-12 col-md-12 col-lg-3 px-0 shadow-btn ">
+                      <a href="/downloads" class="downloads-mobile btn btn-lg btn-outline-secondary btn-icon hero-btn col-sm-12 col-md-12 col-lg-3 px-0 shadow-btn "> <!-- TODO -->

Looks like the front-page download button always goes to the English version of the Downloads page when another language is set.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/260#pullrequestreview-296504812
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191002/c8ad4ad7/attachment.html>