[bisq-network/bisq-website] Remove localhost links (#264)
notifications at github.com
Thu Oct 3 09:24:34 UTC 2019
The additional issues is that the link is hardcoded in the LANG.yml files for all languages. We have `localhost` showing in some Spanish and German pages, but for the other languages we have the value that was originally in the `en.yml`, so basically a link to the English section of the website.
IMO there are 2 ways to fix this:
- Harcode the link to the related language in LANG.yml. So in the example above, the link could be `<a href="https://bisq.network/ja/community/">`
- Split the sentences in more variables, leaving the link out and adding it to the layout. This way every language would pick the correct link for them.
The last option is time consuming and requires small changes to the base layout and to add some variables, but resolves the problem in the long term. The first option is quicker to implement and doesn't require any important change, but will require more attention from future translators (since they will copy and paste that section, they have to be reminded that they need to adapt the link adding the code for thir language).
I think the first option could be good enough in our case.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github