[bisq-network/bisq] Changes needed for minimal api (#3348)

Bernard Labno notifications at github.com
Fri Oct 4 10:17:17 UTC 2019


So that it can be used by subclasses.

-------- Original Message --------
On Oct 4, 2019, 12:15, Christoph Atteneder wrote:

> @ripcurlx commented on this pull request.
>
> ---------------------------------------------------------------
>
> In [core/src/main/java/bisq/core/app/BisqHeadlessApp.java](https://github.com/bisq-network/bisq/pull/3348#discussion_r331433660):
>
>> @@ -43,7 +43,7 @@
>      @Setter
>      private GracefulShutDownHandler gracefulShutDownHandler;
>      private boolean shutDownRequested;
> -    private BisqSetup bisqSetup;
> +    protected BisqSetup bisqSetup;
>
> Why do you need this to be protected instead of private?
>
>> You are receiving this because you authored the thread.
> Reply to this email directly, [view it on GitHub](https://github.com/bisq-network/bisq/pull/3348?email_source=notifications&email_token=AADJHWFH5Y3QODRQXNB3PATQM4JVFA5CNFSM4I4HWOEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG43MOY#pullrequestreview-297383483), or [mute the thread](https://github.com/notifications/unsubscribe-auth/AADJHWG7JMWFXDANYXVZQEDQM4JVFANCNFSM4I4HWOEA).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3348#issuecomment-538339625
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191004/e93a7edc/attachment.html>


More information about the bisq-github mailing list