[bisq-network/bisq] Refactor BisqEnvironment (#3362)

Bernard Labno notifications at github.com
Sat Oct 5 07:57:36 UTC 2019


blabno approved this pull request.

utACK

> @@ -205,158 +205,74 @@ public BisqEnvironment(OptionSet options) {
                 options)));
     }
 
+    private String getProperty (PropertySource properties, String propertyKey, String defaultValue) {

According to Uncle Bob it's good to keep public methods at the top, because they declare contract, while keeping private methods below.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3362#pullrequestreview-297780976
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191005/7f6ac038/attachment.html>


More information about the bisq-github mailing list