[bisq-network/bisq] Hash of ProtectedStoragePayload is non-deterministic (leading to duplication of elements in P2PDataStorage) (#3367)

chimp1984 notifications at github.com
Mon Oct 7 01:00:37 UTC 2019


Oh damn....
The 'extra_data field' is not used in many payloads but in 'OfferPayload' and 'TradeStatistics2' it is used. 
Did you see a different hash in your Rust project? It might be that the issue becomes only relevant if protobuf is used across different languages. 
We need to find a way how to fix that without breaking backward compatibility. There are also maps used in 'DaoState' and in 'Preferences'. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3367#issuecomment-538807289
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191006/5789d8d9/attachment.html>


More information about the bisq-github mailing list