[bisq-network/bisq] Refactor FilterWindow (#3364)

[Łukasz Usarz]

lusarz commented on this pull request.



> @@ -301,4 +248,12 @@ private void addContent() {
         gridPane.getChildren().add(hBox);
         GridPane.setMargin(hBox, new Insets(10, 0, 0, 0));
     }
+
+    private List<String> readAsList(InputTextField field) {
+        if (field.getText().isEmpty()) {
+            return new ArrayList<>();

`Collections.emptyList()` returns an immutable list, so operations like `add` will throw `UnsupportedOperationException`. Are we sure that these lists are not modified anywhere ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3364#discussion_r331885538
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191007/55d83446/attachment.html>