[bisq-network/bisq] Hash of ProtectedStoragePayload is non-deterministic (leading to duplication of elements in P2PDataStorage) (#3367)

Christoph Sturm notifications at github.com
Mon Oct 7 09:16:55 UTC 2019


did you see this happen in the java app or is it a theoretical problem? I'm pretty sure that the ordering in java hashmaps is always the same even if it is not defined. and since we always use the same code it could very well be that this is not really resulting in a problem right now. 

we could also write code that detects this problem and removes the duplicate items. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3367#issuecomment-538911662
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191007/8b199d72/attachment.html>


More information about the bisq-github mailing list