[bisq-network/bisq] Hash of ProtectedStoragePayload is non-deterministic (leading to duplication of elements in P2PDataStorage) (#3367)

[Justin Carter]

Its not theoretical, I have witnessed this problem in my rust re-implementation. I have not yet verified 100% conclusively if this happens in the java app and am currently investigating to find evidence.

But regardless - the order of the entries in a java hashmap is also not guaranteed to stay stable. Even if it is working now any of the following things (and perhaps more) could cause the bug to surface:
- update of the java version
- different JVM implementation
- update to the google pb library

It seems to me like it is very risky to keep this bug around. Especially given the reliance on hashes in the consensus code of the DAO.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3367#issuecomment-538920831
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191007/2547c7ca/attachment.html>