[bisq-network/bisq] Hash of ProtectedStoragePayload is non-deterministic (leading to duplication of elements in P2PDataStorage) (#3367)

[Justin Carter]

I now have proof that this is happening at a non-trivial frequency on the currently live mainnet, independently of my experimentation with rust.

I have compared the serialized bytes for given `OfferPayloads` with unique hashes but same `id` as they were received from the network (this means they were serialized by a java process,  _not_ re-serialized in rust code).

In the time frame I observed out of 52 `AddDataMessage` that contained `OfferPayloads` with unique hashes 13 were actually duplicates with the same `id`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3367#issuecomment-539169163
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191007/3f5b1619/attachment.html>