[bisq-network/bisq] Hash of ProtectedStoragePayload is non-deterministic (leading to duplication of elements in P2PDataStorage) (#3367)

[Justin Carter]

> As a first step. we could add that check to the java version and log it.

Just FYI this is trickier than it seems as you need the `bytes != old_bytes` check to operate on the exact bytes that came from the network _before_ the object gets inflated via `from_proto`. If you just re-serialize the objects the bytes probably wont differ since locally the hashing may be deterministic.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3367#issuecomment-539428064
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191008/f361888d/attachment.html>