[bisq-network/bisq-website] New multilanguage system (#260)

erciccione notifications at github.com
Tue Oct 8 13:14:53 UTC 2019


@wiz thank you for your review, i'm implementing some changes now. I see a good amount of your comments are not related to the source code, but to the resulting jekyll built. Maybe it's my bad habit but i never really care too much about it, since it's mostly useful only for the reviewer (makes easier to compare the two builds, but nothing more) and for extremely minor things, like the duplicate comments.

> Can you also "view source" of every page and fix the extra spaces...

You are getting very nitpicky today :P. Please consider that with a major overhaul like the one introduced by this PR, it is normal that the resulting jekyll build (i guess you are referring to that since i don't see the problem in the source code) is slightly different from the precedent build. The point of this PR is to introduce a scalable system to develop on and easy to maintain. We are removing more than 60 duplicated files and editing 124. I think we can expect some minor (and irrelevant) differences.

> you really gotta be careful when doing blanket search and replace like this 

I used `sed` at the beginning to replace some strings, but i stopped immediatly after i saw there were too many variables to keep track of, this is a leftover from my cleanup. I apologize for forgetting it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/260#issuecomment-539507503
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191008/6ffe3e62/attachment.html>


More information about the bisq-github mailing list