[bisq-network/bisq-website] New multilanguage system (#260)

Steve Jain notifications at github.com
Tue Oct 8 19:35:09 UTC 2019

@erciccione I think the point wiz is trying to make is that if this is a refactor, the resulting built code base and functionality should be the same. In some cases it matters more than others...but from the not-irrelevant errors wiz has uncovered (e.g., stray HTML showing on page, mobile menu items differences, old translations, etc), I start to wonder about the integrity of the proposed changes (i.e., what else is there that we are not catching?).

Minor or major, why is it that we're seeing such errors if this PR is supposed to essentially be a refactor of how/which strings are delivered to the user? Not at all saying any of this is trivial, but I'm not understanding how the resulting differences in this PR came about...and they do make me a bit uneasy.

For what it's worth, I will be devising a process to more rigorously review PRs from now on.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191008/5e65d50d/attachment.html>

More information about the bisq-github mailing list