[bisq-network/bisq] Hash of ProtectedStoragePayload is non-deterministic (#3367)

[Justin Carter]

> I also counted the number of OfferPayloads and it was the same number (308) as the displayed offers, so it seems there are no duplicates entry in the map.

Duplication in the map does not occur in Java because locally the hashing is deterministic. The issue only shows up in the interaction between nodes because _globally_ its non-deterministic.

In rust this is different. Its non-deterministic _even locally_ which leads to the duplication and is why I spotted it. This is because the order of entries in rust's HashMap implementation is randomized by design for security reasons. It makes a certain category of attacks much harder.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3367#issuecomment-540124259
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191009/fabb6bcc/attachment-0001.html>