[bisq-network/bisq] Hash of ProtectedStoragePayload is non-deterministic (#3367)

Justin Carter notifications at github.com
Wed Oct 9 18:54:36 UTC 2019


No that isn't the issue. I use `parseFrom` because I have already parsed the size (I need it to know how big the byte array should be). The `parseDelimitedFrom` just does the size parsing inline. Either way the method `toBytesArray` (used for hashing) yields the version without the size delimination. So I haven't added the bytes that encode the size originalBytes array. Otherwise the lenght of the arrays would be different.
That the last couple of bytes are different are an indication that its the `extra_fields` map that is the issue (its the 2nd to last field in the serialization). If the size parsing was an issue it would show up in the very first bytes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3367#issuecomment-540140098
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191009/b66030cf/attachment.html>


More information about the bisq-github mailing list