[bisq-network/bisq] Verify the assumption that a HashMap orders keys. (#3389)

Justin Carter notifications at github.com
Thu Oct 10 18:58:59 UTC 2019

Afaict internally `LinkedHashMap` is [being used](https://github.com/protocolbuffers/protobuf/blob/f9d8138376765d229a32635c9209061e4e4aed8c/java/core/src/main/java/com/google/protobuf/MapField.java#L171) which actually preserves order and would thus make this test fail. In other words the behaviour is different depending on if we create it then serialize it (all key-orders lead to same bytes), or de-serialize it from the wire (due to `LinkedHashMap` internally it becomes order sensitive).

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191010/39298169/attachment.html>

More information about the bisq-github mailing list