[bisq-network/bisq] Verify the assumption that a HashMap orders keys. (#3389)

Justin Carter notifications at github.com
Fri Oct 11 19:14:44 UTC 2019


I don't really see how this test is useful. What would be actionable if it breaks?
In order for bisq to remain stable it is not really important that insert order is deterministic. Its much more important that order remains stable during the deserialize -> reserialize process. If _that_ breaks down bisq is completely broken.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3389#issuecomment-541190023
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191011/0c9f3485/attachment.html>


More information about the bisq-github mailing list