[bisq-network/bisq] Takers can accept an offer where the maker's initial transaction was never propagated (#3395)
notifications at github.com
Fri Oct 11 21:24:12 UTC 2019
Bugs can currently cause a transaction to fail to broadcast on chain, but bisq will still allow an invalid offer to be taken. This will cause a stuck trade which requires mediation or arbitration to close cleanly. It can also lead to a further bug with mediation causing a trader to be unable to accept the mediator's resolution with error:
message='An error occurred at task: SignMediatedPayoutTx
Exception message: trade.getDepositTx() must not be null'
As a quick fix I suggest a check when an offer is taken that the deposit tx is valid or possibly confirmed on chain. Ideally the offer maker would be notified that their tx was not broadcast soon after they create it as they could then remove the offer and fix the issue their end. I'm willing to work on this myself if the idea is sound.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github