[bisq-network/bisq] [1.2.0] Time locked payout is paid without initiating support (arbitration) (#3463)

[Devin Bileck]

### Description

When taking an offer and not initiating/confirming payment or opening a support ticket, when I generate blocks until exceeding the timelock period nothing happens (as expected). But once either client restarts (Alice or Bob), it pays out to the donation address immediately upon restart. As far as I am aware, the payout should only occur if any trader opens an arbitration ticket (refund agent).

#### Version

release/v1.2.0 branch (commit cd4cd39206c22b29db77a6b082a00127605416c4)

### Steps to reproduce

Preconditions:
- Start with a fresh regtest environment (using the dao-setup.zip file)
- Adjust the delay in MakerSetsLockTime to only 5 blocks to make testing easier
- Change RECIPIENT_BTC_ADDRESS to an address of your local regtest Bitcoin Core node

Steps:
1. Alice creates a buy offer and Bob takes the offer (do not initiate payment).
2. Generate blocks until exceeding the timelock delay period.
3. Restart Bob's client.

### Expected behaviour

The time locked payout should NOT be paid.

### Actual behaviour

The time locked payout is paid to the RECIPIENT_BTC_ADDRESS as soon as the client restarts.

#### Device or machine

Windows 10

#### Additional info

There are no errors in the log, and I don't see any indication that publishDelayedPayoutTx was called. However, I do see the transaction broadcast:
```
Oct-24 14:56:08.150 [ STARTING] INFO  org.bitcoinj.wallet.Wallet: New broadcaster so uploading waiting tx 93e1c52388f235136d213a5f4204c1508e48a9553d392e6b49ff792ce074d6fa 
Oct-24 14:56:08.155 [ STARTING] INFO  o.b.core.TransactionBroadcast: Waiting for 1 peers required for broadcast, we have 0 ... 
```
```
Oct-24 14:56:10.349 [JavaFX Application Thread] INFO  o.b.core.TransactionBroadcast: broadcastTransaction: We have 1 peers, adding 93e1c52388f235136d213a5f4204c1508e48a9553d392e6b49ff792ce074d6fa to the memory pool 
Oct-24 14:56:10.353 [JavaFX Application Thread] INFO  o.b.core.TransactionBroadcast: Sending to 1 peers, will wait for 0, sending to: [127.0.0.1]:18444 
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3463
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191024/a4bd72bd/attachment.html>