[bisq-network/bisq] Do not commit delayedPayoutTx to avoid publishing at restart (#3464)

chimp1984 notifications at github.com
Fri Oct 25 03:46:22 UTC 2019


Fixes https://github.com/bisq-network/bisq/issues/3463

BitcoinJ publishes automatically committed transactions.
We committed it to the wallet to be able to access it later after a
restart. We stored the txId in Trade and used that to request the tx
from the wallet (as it was committed). Now we store the
bitcoin serialized bytes of the tx and do not commit the tx before
broadcasting it (if a trader opens refund agent ticket).
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3464

-- Commit Summary --

  * Do not commit delayedPayoutTx to avoid publishing at restart

-- File Changes --

    M common/src/main/proto/pb.proto (2)
    M core/src/main/java/bisq/core/trade/Trade.java (20)
    M core/src/main/java/bisq/core/trade/protocol/tasks/buyer/BuyerProcessDepositTxAndDelayedPayoutTxMessage.java (8)
    M core/src/main/java/bisq/core/trade/protocol/tasks/seller/SellerFinalizesDelayedPayoutTx.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3464.patch
https://github.com/bisq-network/bisq/pull/3464.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3464
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191024/5a99c229/attachment.html>


More information about the bisq-github mailing list