[bisq-network/bisq] SeedNodes report duplicate TradeStatistics2 (same OfferId different Hash) (#3468)

[Justin Carter]

When requesting data from a seednode the `GetDataReponse`  [`persistable_network_payload_items`](https://github.com/bisq-network/bisq/blob/master/common/src/main/proto/pb.proto#L97) array contains many [`TradeStatistics2`](https://github.com/bisq-network/bisq/blob/master/common/src/main/proto/pb.proto#L594-L611) messages that are actually duplicates.
ie. Same `offer_id` but different `hash` fields. It appears as though [this hashing function](https://github.com/bisq-network/bisq/blob/master/core/src/main/java/bisq/core/trade/statistics/TradeStatistics2.java#L157) is infact non-deterministic and truly yields different results in prod in the wild (unlike the other non-deterministic hashing issue that does not appear to manifest itself).

Here is an example of 2 TradingStatistics2 messages received from the seed nodes:
```
{
        "direction": "SELL",
        "price": "7199.12320000",
        "amount": "0.03000000",
        "volume": "215.97360000",
        "payment_method": "SEPA",
        "trade_id": "DAtKiw-6951da2b-38e0-44ed-9b17-4935cf85aff3-117",
        "trade_date": "1571920381023",
        "hash": "7318687539069de402ca208ce8c8dfe93aa3326e"
      },
      {
        "direction": "SELL",
        "price": "7199.12320000",
        "amount": "0.03000000",
        "volume": "215.97360000",
        "payment_method": "SEPA",
        "trade_id": "DAtKiw-6951da2b-38e0-44ed-9b17-4935cf85aff3-117",
        "trade_date": "1571920381023",
        "hash": "7a229b08c04ded7f2247feb6b25d35f0335dbef6"
      }
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3468
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191025/24ce98fe/attachment.html>