[bisq-network/bisq-docs] Update DAO tx structure doc (#171)

sqrrm notifications at github.com
Sun Oct 27 22:50:34 UTC 2019


sqrrm commented on this pull request.



> @@ -109,7 +109,14 @@ Sending BSQ to another address is a simple transaction without OpReturn. It requ
 as well as a BTC input to cover the miner fee. The outputs are the receiver's BSQ address, an optional BSQ change output,
 and an optional BTC change output.
 
-A transaction to send 10 BSQ could look like this:
+- Inputs [1-n]: Mandatory BSQ inputs for BSQ transfer
+- Inputs [1-n]: Mandatory BTC inputs for miner fee
+- Output  [1]: Mandatory BSQ output

I think this should be `Output  [1-n]: Mandatory BSQ output(s)`

We allow multiple BSQ outputs until `availableInputValue` doesn't cover the next output.

> @@ -109,7 +109,14 @@ Sending BSQ to another address is a simple transaction without OpReturn. It requ
 as well as a BTC input to cover the miner fee. The outputs are the receiver's BSQ address, an optional BSQ change output,
 and an optional BTC change output.
 
-A transaction to send 10 BSQ could look like this:
+- Inputs [1-n]: Mandatory BSQ inputs for BSQ transfer
+- Inputs [1-n]: Mandatory BTC inputs for miner fee
+- Output  [1]: Mandatory BSQ output

The genesis tx is doing this, although it's somewhat special I think it's still right to show that 1-n BSQ outputs are allowed.

> @@ -165,13 +179,14 @@ It is first hashed with Sha256 and then with Ripemd160 to get a 20 byte hash.
 Compensation request tx and reimbursement request txs are technically the same and inherit the properties of a
 proposal tx but have some additional requirements. They add a BTC output which will be interpreted as a BSQ output at the vote result phase in case the request is accepted by voting.
 
-- Inputs [1-n]: BSQ inputs for BSQ fee
-- Inputs [1-n]: BTC inputs BSQ issuance and miner fee
-- Output [1]: Mandatory BSQ output (BSQ input - fee)
-- Outputs [1]: Issuance candidate output; before voted ok it is BTC afterwards newly issued BSQ
-- Outputs [0-1]: BTC change output
+- Inputs [1-n]: Mandatory BSQ inputs for BSQ fee
+- Inputs [0-n]: Optional BTC inputs BSQ issuance and optionally miner fee
+- Output [1]: Mandatory BSQ change output
+- Outputs [1]: Mandatory issuance candidate output; before voted ok it is BTC afterwards newly issued BSQ

It only becomes BSQ after a vote of acceptance, might be worth noting

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-docs/pull/171#pullrequestreview-307582853
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191027/8204dda2/attachment-0001.html>


More information about the bisq-github mailing list