[bisq-network/bisq] Check for result phase at activate method (#3492)

[Devin Bileck]

devinbileck requested changes on this pull request.

NACK
The vote results are only populated if viewing the results on the first block of the results phase. If you try to view the results after that, they are still empty.

> @@ -238,7 +239,11 @@ protected void deactivate() {
 
     @Override
     public void onParseBlockCompleteAfterBatchProcessing(Block block) {
-        int chainHeight = daoStateService.getChainHeight();
+        checkForResultPhase(daoStateService.getChainHeight());
+        fillCycleList();
+    }
+
+    private void checkForResultPhase(int chainHeight) {
         if (periodService.getFirstBlockOfPhase(chainHeight, DaoPhase.Phase.RESULT) == chainHeight) {

Shouldn't this be `<= chainHeight`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3492#pullrequestreview-307672422
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191028/17724474/attachment.html>