[bisq-network/proposals] Improve support and prioritize bug fixes in trade process (#130)

[chimp1984]

>  invalid Bitcoin transaction
 
Do you have some log files showing the invalid tx? We verify each tx before its committed to the wallet and I think the commit method itself would throw an exception in case of an invalid tx. Though low miner fee or if fee is < min. relay fee is not covered by that. Also possible unintended doublespends on the inputs.

> TX created with < 1 sat/vbyte fee
That is for normal withdrawal txs. Trade txs use the fee estimation and I doubt that it is ever that low. But we should double check if there is a ceck for min 1 sat from that side.

> a "virus" 

I think that is a bit misleading term ;-).
If a user has a corrupted addressEntryList and/or wallet those situations happen that the taker fee tx is never broadcast (for so far unknown reasons) and as the maker is not verifying the taker tx the deposit is created but will be invalid as the taker fee tx as one of the inputs does not exist. If the tx is valid itself verification would also not help, also BitcoinJ cannot verify as much as a full node as it does not has the inputs of a foreign tx. Checking for confirmation or even if its in the mempool would require more delay and we cannot rely on it that we will ever see the tx before its confirmed, whcih would obviously take way too long for the taker offer process (executed in seconds).

But I agree it seems that you as maker will get corrupted as well your wallet by having spent funds to an non-existing tx and when using the change your might become the reason for the next failure case. So in that regard, the bug behaves a bit like a virus ;-).

Maybe its better we start a GH issue for collecting the information (logs) we have to not derail that proposal as too much technical bug report thread....

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/130#issuecomment-547180541
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191028/5626aa9d/attachment.html>