[bisq-network/bisq] Validate phone numbers (#3149)

Christoph Atteneder notifications at github.com
Mon Sep 2 07:28:02 UTC 2019


> FYI, HalCash required a couple of changes to pb.proto. So may others.


Changing stuff in the proto file must be done very carefully, as this could cause backwards compatibility issues. But I'll have a look at it in your upcoming PR.

> For example, the next PR will be "Validate HalCash phone number", then a few to several (depending on similarity of changes needed) phone-validator integrations can be grouped into the next PR, and so on.
> 
> Each PR would benefit users of each affected payment method, and testers wouldn't need to test everything all at once.

Sounds reasonable.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3149#issuecomment-527034968
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190902/2c66cc91/attachment.html>


More information about the bisq-github mailing list