[bisq-network/bisq] Remove bcprov from direct dependencies - a major step towards eventually removing Bouncy Castle (#3195)

battleofwizards notifications at github.com
Tue Sep 3 14:30:59 UTC 2019


battleofwizards commented on this pull request.



> + */
+
+package bisq.common.util;
+
+import com.google.common.io.BaseEncoding;
+
+public class Hex {
+
+    public static byte[] decode(String hex) {
+        return BaseEncoding.base16().lowerCase().decode(hex.toLowerCase());
+    }
+
+    public static String encode(byte[] bytes) {
+        return BaseEncoding.base16().lowerCase().encode(bytes);
+    }
+}

Yes, I am aware of Utilities and BitcoinJ versions of Hex being used in the code. It did cross my mind to standardize this but I decided it is too broad for this PR.

In this PR I focused on minimizing the diff and ensuring backwards compatibility. We need exactly the same behavior from replacements as original Bounce Castle versions.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3195#discussion_r320304816
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190903/ae130c81/attachment.html>


More information about the bisq-github mailing list