[bisq-network/bisq] Fix offer volume jumps (#3194)
Christoph Atteneder
notifications at github.com
Wed Sep 4 11:35:08 UTC 2019
ripcurlx requested changes on this pull request.
NACK - Please see my comment.
> @@ -1208,4 +1216,35 @@ private void stopTimeoutTimer() {
private BSFormatter getFormatterForMakerFee() {
return dataModel.isCurrencyForMakerFeeBtc() ? btcFormatter : bsqFormatter;
}
+
The code works as expected atm, but I think this part of the could should be moved into the MutableOfferViewDataModel.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3194#pullrequestreview-283551186
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190904/68ed61d8/attachment.html>
More information about the bisq-github
mailing list