[bisq-network/bisq-website] Refactored "Statistics" page to make it more i18n friendly (#221)
Steve Jain
notifications at github.com
Wed Sep 4 16:26:39 UTC 2019
m52go commented on this pull request.
Looks good to me. Just 1 missed translation, which I noted with a suggestion.
> - <p class='stat-label'>Total des transactions</p> <p class='stat-figure'>32,318</p> <p class='stat-note'>Pour Juin 2019</p>
- pDailyAverage: >
- <p class='stat-label'>Moyenne journalière des transactions</p> <p class='stat-figure'>94</p> <p class='stat-note'>En Juin 2019</p>
- pSoftwareDownloads: >
- <p class='stat-label'>Téléchargements du logiciel</p> <p class='stat-figure'>13,723</p> <p class='stat-note'>For v1.1.2 (approximation)</p>
- pGithubContributors: >
- <p class='stat-label'>Contributeurs GitHub </p> <p class='stat-figure'>172</p> <p class='stat-note'>En Juin 2019</p>
- pTwitterFollowers: >
- <p class='stat-label'>Followers sur Twitter </p> <p class='stat-figure'>17,588</p> <p class='stat-note'>En Juin 2019</p>
- pSlackUsers: >
- <p class='stat-label'> Utilisateurs Slack</p> <p class='stat-figure'>1,183</p> <p class='stat-note'>En Juin 2019</p>
+ pTotalTrades: Total des transactions
+ pTotalDate: Au cours du mois dernier
+ pDailyAverageTrade: Moyenne journalière des transactions
+ pSoftwareDownloads: Téléchargements du logiciel
+ pSoftwareDownloadsVersion: For v1.1.2 (approximation)
Still English. This looks like a decent translation from my time taking French.
```suggestion
pSoftwareDownloadsVersion: Pour v1.1.2 (environ)
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/221#pullrequestreview-283739700
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190904/33b038f4/attachment.html>
More information about the bisq-github
mailing list