[bisq-network/bisq] periodical UpdateDataReq for Seednodes (#3202)
Florian Reimair
notifications at github.com
Thu Sep 5 05:24:52 UTC 2019
freimair commented on this pull request.
> @@ -337,11 +340,13 @@ public void onPreliminaryDataReceived() {
@Override
public void onUpdatedDataReceived() {
- isBootstrapped = true;
- maybeProcessAllMailboxEntries();
- p2pServiceListeners.stream().forEach(P2PServiceListener::onUpdatedDataReceived);
- if(!isBootstrapped)
- p2PDataStorage.onBootstrapComplete();
+ if (!isBootstrapped() || Capabilities.app.containsAll(Capability.SEED_NODE)) {
+ isBootstrapped = true;
+ maybeProcessAllMailboxEntries();
+ p2pServiceListeners.stream().forEach(P2PServiceListener::onUpdatedDataReceived);
+ if (!isBootstrapped)
+ p2PDataStorage.onBootstrapComplete();
+ }
Ahm I am not a fan of squashing commits, because:
- if a reviewer wants to see individual commits (because there is far less a change than all of them), he can just click them
- if a reviewer wants to see all changes, he can review in the [Files]-Tab...
as for your comment, these `if`s are strange. Onto it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3202#discussion_r321078648
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190904/03ff491c/attachment-0001.html>
More information about the bisq-github
mailing list