[bisq-network/bisq] Fix offer volume jumps (#3194)

Christoph Atteneder notifications at github.com
Thu Sep 5 07:26:13 UTC 2019


ripcurlx commented on this pull request.



> @@ -1208,4 +1216,35 @@ private void stopTimeoutTimer() {
     private BSFormatter getFormatterForMakerFee() {
         return dataModel.isCurrencyForMakerFeeBtc() ? btcFormatter : bsqFormatter;
     }
+

On second look, yes it is not really feasible to move everything into the data model. Please move only the calculation part as you suggested to the data model. There is already a block of calculate... methods there. Besides that and the naming of the update method ACK

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3194#discussion_r321110399
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190905/4dd4d30b/attachment.html>


More information about the bisq-github mailing list