[bisq-network/bisq] Remove PGP keys from the KeyRing (#3207)

battleofwizards notifications at github.com
Thu Sep 5 12:42:34 UTC 2019


The PGP support was envisioned in the KeyRing but never fully implemented. This removes the (essentially) dead code.

This code impeded my understanding on how we use signatures. My initial impression was that we use PGP for p2p message signing, which is not the case.

The protobuf message compatibility is implemented with `reserved`.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3207

-- Commit Summary --

  * Remove PGP keys from the KeyRing

-- File Changes --

    M common/src/main/java/bisq/common/crypto/KeyRing.java (23)
    M common/src/main/java/bisq/common/crypto/KeyStorage.java (16)
    D common/src/main/java/bisq/common/crypto/PGP.java (134)
    M common/src/main/java/bisq/common/crypto/PubKeyRing.java (29)
    M common/src/main/proto/pb.proto (2)
    M core/src/test/java/bisq/core/arbitration/ArbitratorTest.java (3)
    M core/src/test/java/bisq/core/arbitration/MediatorTest.java (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3207.patch
https://github.com/bisq-network/bisq/pull/3207.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3207
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190905/0a0a11f9/attachment.html>


More information about the bisq-github mailing list