[bisq-network/bisq] Add average bsq price (#3212)

Christoph Atteneder notifications at github.com
Fri Sep 6 08:03:26 UTC 2019


ripcurlx commented on this pull request.



> @@ -1022,4 +1050,22 @@ public static void openTxInBsqBlockExplorer(String txId, Preferences preferences
         if (txId != null)
             GUIUtil.openWebPage(preferences.getBsqBlockChainExplorer().txUrl + txId, false);
     }
+
+    public static String getBsqInUsd(Price bsqPrice,

We do have a mixture of in the codebase right now, but I would set BSQ always in uppercase to be able to differentiate it quicker from Bisq. Besides that utACK

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3212#pullrequestreview-284711803
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190906/9e138e53/attachment.html>


More information about the bisq-github mailing list